fix: swiftly is stuck during dependency check on Fedora#520
Open
terraputix wants to merge 1 commit intoswiftlang:mainfrom
Open
fix: swiftly is stuck during dependency check on Fedora#520terraputix wants to merge 1 commit intoswiftlang:mainfrom
terraputix wants to merge 1 commit intoswiftlang:mainfrom
Conversation
terraputix
requested review from
cmcgee1024,
etcwilde,
justice-adams-apple and
shahmishal
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #490.
The underlying issue was that using
.discardedinstead of.string(limit: 100 * 1024)will hang when waiting for user input. I verified this byrunning a bash script which waits for user input instead ofyum list installed(from the changed line).Since
result.standardOutputis not currently being used thelimit: 100 * 1024could be smaller, but for simplicity I used the same value as in theapt-getversion.Moreover,
yum list installedis not fully correct. Compare the following:This shows that using
--installedinstead ofinstalledwill correctly return a non 0 exit code if a package is not installed.